feat(api): Expose defaults #358
Merged
+683
−599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obartra
force-pushed
the
expose-defaults
branch
2 times, most recently
from
d7cba67 to
e2595ae
Compare
arahansen
approved these changes
Jan 9, 2018
circle.yml
Outdated
| @@ -22,6 +22,7 @@ test: | |||
| override: | |||
| - yarn build | |||
| - scripts/citests.sh: | |||
| timeout: 1200 | |||
| parallel: true | |||
There was a problem hiding this comment.
What issue were you seeing here?
There was a problem hiding this comment.
I'm still debugging this, this is not the right solution though.
iphone7 tests were timing out (still are) I thought we had too many stories but looking at saucelabs it seems like it's not completing correctly and re-trying.
It may be related to the picturebook update
There was a problem hiding this comment.
Looks like the issue is related to the storybook update and iphone 7. I'll look into it separately #359
obartra
force-pushed
the
expose-defaults
branch
2 times, most recently
from
2963679 to
f989f2b
Compare
obartra
force-pushed
the
expose-defaults
branch
from
f989f2b to
9b3aa4e
Compare
This was referenced Jan 11, 2018
|
🎉 This PR is included in version 16.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import dev version in react while preserving unpkg compatibility.
Closes #357 #355 #342